-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Cells #51
base: master
Are you sure you want to change the base?
Merge Cells #51
Conversation
@bprasetyo Thanks, can you describe your use case for this feature? |
@felixbuenemann thanks for your reply, but to keep width of cell for data table, i need to merge column A1 and A2 same with column of data table (A1:C1 and A2:C2) instead of using single cell which make column A4-A16 too wide. also, like this too: i know gem Axlsx is good for styling an data excel, but in a real case, i have a big data which needed to create to report like this. |
I understand if people disagree, but I think the pros of adding this (more capability) should be weighted against added complexity. The primary reason being to keep the complexity down, which makes the project easier to maintain over time. Maybe it would make sense to add a 'discussions' tab to this repo (github feature) and gauge interested before certain capabilities are added? |
With
@sandstrom it does seem like a nice addition and I don't see how it causes a lot of cognitive load on the user if you do not have to use it? |
@julik I'm not concerned about cognitive load on the user. I'm thinking about maintenance for this project, and that feature requests with zero upvotes (a single person has suggested it) are often not worth the effort. The benefit with a discussions tab is that one can measure interest with e.g. upvotes. Obviously as a project maintainer (I'm not a maintainer here) you can always choose to implement anything. It's just a pattern that some open-source projects take on a scope that's too large, and then eventually becomes impossible to maintain. |
Thank you for your perspective. I have spoken to Felix and I am co-maintainer on this library as of this year. I agree with you that learning to say "no" to feature proposals / feature requests is an important virtue - and even more so with open-source than with commercial software, as the feature proposal can come in the form of already accomplished changeset - which makes it ever more tempting to just accept. That said, this feature does seem small and contained enough that it should not bee to much of a burden going forward. |
The main goal of this gem ist to dump rows of data to an Excel spreadsheet similar to the csv gem, so I don’t think we need this feature. Also Excel already overflows text into neighboring columns, if they are empty. |
@sandstrom I agree with your view on keeping the feature set focused to reduce the maintenance burden. |
Add feature merge cells
From this:

To this:
